[Bug 226275] Merge Review: perl-PDL

bugzilla at redhat.com bugzilla at redhat.com
Tue Jul 31 21:55:16 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-PDL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226275


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |orion at cora.nwra.com




------- Additional Comments From orion at cora.nwra.com  2007-07-31 17:55 EST -------
rpmlint:

W: perl-PDL macro-in-%changelog description

- can be ignored

W: perl-PDL mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)

- Fixed in patch

I think the Summary should be changed to something like "The Perl Data Language".

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL/Artistic) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Consider including some more files in %doc:
BUGS
Changes
Known_problems
Release_Notes

A number of PDL modules are not being built that could be.  I'll be attaching a
number of patches that enable them as well as getting PDL to build for devel again.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list