[Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jun 4 06:44:32 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mrxvt - Multi-tabbed terminal emulator.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-06-04 02:44 EST -------
Well, for 0.5.2-1.2:
* Souce URL
- The format of URL for Source0 and Patch1 is still incorrect.
For sources on sourceforge.net, again please refer to
http://fedoraproject.org/wiki/Packaging/SourceURL
(especially, the section "Sourceforge.net")
* Directory ownership
- What I want to say is that the directory %{_sysconfdir}/mrxvt/
is not owned by this package.
-------------------------------------------------
[root at localhost ~]# LANG=C rpm -qf /etc/mrxvt
file /etc/mrxvt is not owned by any package
-------------------------------------------------
You must add:
-----------------------------------------------
%dir %{_sysconfdir}/mrxvt
-----------------------------------------------
to %files list. i.e. You must use:
-----------------------------------------------
%dir %{_sysconfdir}/%{name}
%config(noreplace) %{_sysconfdir}/%{name}/default.menu
%config(noreplace) %{_sysconfdir}/%{name}/mrxvtrc
%config(noreplace) %{_sysconfdir}/%{name}/mrxvtrc.sample
%config(noreplace) %{_sysconfdir}/%{name}/submenus.menu
-----------------------------------------------
... or just:
-----------------------------------------------
%config(noreplace) %{_sysconfdir}/%{name}/
-----------------------------------------------
NOTE:
--------------------------------------------
%files
foo/
--------------------------------------------
(where foo/ is a directory) means the directory foo/ itself
and all files/directories/etc.. under foo/, while
--------------------------------------------
%files
%dir foo/
--------------------------------------------
means the directory foo/ only.
- Also, the directory %{_datadir}/doc/%{name}/scripts/ should
be owned by this package.
* Macros
- "%{_prefix}/share" should be %{_datadir}.
- And,
---------------------------------------------
%{_prefix}/share/pixmaps/mrxvt-csh.png
%{_prefix}/share/pixmaps/mrxvt-csh.xpm
%{_prefix}/share/pixmaps/mrxvt-root.png
%{_prefix}/share/pixmaps/mrxvt-root.xpm
%{_prefix}/share/pixmaps/mrxvt.png
%{_prefix}/share/pixmaps/mrxvt.xpm
----------------------------------------------
can be replaced with
----------------------------------------------
%{_datadir}/pixmaps/%{name}*
----------------------------------------------
* Documentation
- And all the files under %{_datadir}/doc/%{name} must be moved
to %{_datadir}/doc/%{name}-%{version}.
* Unneeded macros, comments
- Remove unneeded macros and comments.
* It doesn't seem that the macro %enable_trace is used
anywhere.
* Changelog formats
- The correct format is like:
------------------------------------------------------
* Thu May 31 2007 Adam M. Dutko <gnome at dux-linux org> - 0.5.2-1.1
- Updated spec file per suggestions in bug #: 223422
------------------------------------------------------
- And the release number should be integer + %{?dist}.
(although there are some exceptions: please check:
"Package Release" of
http://fedoraproject.org/wiki/Packaging/NamingGuidelines )
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list