[Bug 229419] Review Request: glew - The OpenGL Extension Wrangler Library

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 4 21:16:39 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glew - The OpenGL Extension Wrangler Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229419





------- Additional Comments From bruno at postle.net  2007-06-04 17:16 EST -------
(In reply to comment #7)
>> 
> Don't use %makeinstall, use patch attached above and make install 
> DESTDIR=$RPM_BUILD_ROOT

Thanks, I've included the patch

> New release 1.4.0 is out, update your package

Done.

> License should be changed to "Assorted licenses, see
> %{_docdir}/%{name}-%{version}/copyright_summary" and copyright_summary needs to
> be created, using the debian copyright info as a starting point makes sense.

Done, I've included the debian summary, though rpmlint complains about the
non-standard license text

> Maybe creating a -doc subpackage makes sense, the source tarball has a doc dir
> with html documentation that can be installed.

Makes sense, here it is rebuilt for fc6:

http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/6/x86_64/SRPMS.panorama/glew-1.4.0-1.fc6.src.rpm
http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/glew.spec
http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/glew-1.4.0-makefile.patch
http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/glew-copyright_summary

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list