[Bug 225846] Merge Review: gnu-efi

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnu-efi


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225846


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

dcantrell at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|nobody at fedoraproject.org    |dcantrell at redhat.com
               Flag|                            |needinfo?(clumens at redhat.com
                   |                            |)




------- Additional Comments From dcantrell at redhat.com  2007-06-11 14:21 EST -------
W: gnu-efi no-url-tag
W: gnu-efi setup-not-quiet
E: gnu-efi hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/gnuefi
E: gnu-efi hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/*.o
E: gnu-efi hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/gnuefi
E: gnu-efi hardcoded-library-path in /usr/lib/*

Release has no %{?dist} tag.  Do we need that?  I kind of like them, but I guess
it doesn't matter.

BuildRoot needs to be the huge version:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Use %{?_smp_mflags} if it works in %build.

Line 19 has a trailing space.  Line 30 begins with a tab.  Fugly.

In the %files section, use %defattr(-,root,root,-)

In the %install and %files sections, use path macros.

And you know my personal opinion on %{buildroot} vs. $RPM_BUILD_ROOT.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.