[Bug 243187] Review Request: edac-utils - user space utilities for EDAC subsystem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: edac-utils - user space utilities for EDAC subsystem


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243187


jwilson at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From jwilson at redhat.com  2007-06-13 14:27 EST -------
Review of latest version:

http://people.redhat.com/arozansk/edac-utils/edac-utils-0.9-3.fc7.src.rpm

* source files match upstream:
f19e0695c09cf707953e9584a03df1e1b8f3f423814ac5ea9b70aeb082f071a6 
edac-utils-0.9.tar.bz2
f19e0695c09cf707953e9584a03df1e1b8f3f423814ac5ea9b70aeb082f071a6 
../edac-utils-0.9.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is sufficient. (could be enhanced slightly, but meets minimum reqs)
* license field matches the actual license - GPL
* license is open source-compatible (GPL), text is included in package
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (fedora-devel-x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane.
* ldconfig run when shared libraries are installed.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets do the right thing.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in -devel.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app, so no GUI deps.

Package approved, import at will.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.