[Bug 243831] Review Request: rsyslog - the enhanced syslogd for Linux and Unix

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rsyslog - the enhanced syslogd for Linux and Unix


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243831





------- Additional Comments From tmraz at redhat.com  2007-06-14 03:39 EST -------
Well the advertising clause is removed in the newer glibc sources. As the
University of California given up the advertising clause it 'should' be possible
to remove it here as well. The question is whether the later changes when the
code was part of the klogd are covered by the advertising clause or not. But
IANAL so this should be consulted with them.

But I tried to simply remove the syslog.c alltogether and use the glibc's
implementation and it seems to work fine. Even more with the included syslog.c
'#000' is appended to every log message but that might be some problem i rsyslog
as well. When glibc syslog is used it doesn't happen.

But the klogd has another problem - it calls syslog() from signal handler and
this shouldn't be done if we call glibc's syslog() as this is not signal handler
safe function. To interrupt the read() so the klogd is killed immediately and
not after kernel message arrives sigaction() should be used instead of signal()
to set the signal handlers and just set a flag in the signal handler to exit the
main loop.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.