[Bug 244536] Review Request: postgresql-table_log - Log data changes in a PostgreSQL table

bugzilla at redhat.com bugzilla at redhat.com
Sun Jun 17 10:31:51 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-table_log - Log data changes in a PostgreSQL table


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244536





------- Additional Comments From devrim at commandprompt.com  2007-06-17 06:31 EST -------
Hi Ruben,

(In reply to comment #1)

> - How about postgresql-tablelog for the package name instead of
postgresql-table_log?

The name of the software is table_log, so I did not want to change it...

> - BuildRoot should be one of 
>    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>    %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
>    %{_tmppath}/%{name}-%{version}-%{release}-root

Oops, fixed.

> - Maybe rename README.table_log to just README

Since it will go to contrib directory of PostgreSQL, we want to stick the naming
guidelines there. It is in the form README.nameofthesoftware.

Thanks for the review. I did not bump up the spec file version; but updated spec
and srpm at the website:

Spec URL:
http://developer.postgresql.org/~devrim/rpms/other/table_log/postgresql-table_log.spec
SRPM URL:
http://developer.postgresql.org/~devrim/rpms/other/table_log/postgresql-table_log-0.4.4-1.fc7.src.rpm

Regards, Devrim


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list