[Bug 245081] Review Request: libp11 - a small library for dealing with PKCS#11 tokens
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 21 16:34:57 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libp11 - a small library for dealing with PKCS#11 tokens
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245081
------- Additional Comments From mra at hp.com 2007-06-21 12:34 EST -------
Thanks for the suggestions, I've updated the spec file and built a
libp11-0.2.2-2.src.rpm that is in the same directory as before.
I took your advice and got rid of %prerun and used the suggested %post and
%postrun command format.
The dash is fixed, and I put version numbers in the changelog as per the guidelines.
I've added the html, README and ChangeLog files to the libp11 base package for
documentation.
I also created a libp11-devel package like you suggested and added the doc/api
directory along with the examples directory for the documentation there.
I looked for an example of a -static package, and wasn't able to find any.
Searching on my system I found several .a files that were registered in the
-devel packages so for now I did not create a -static. If anyone knows of an
example I could follow I will.
The libtool dependency should have really just been a BuildRequires
libtool-ltdl-devel since libp11 needs ltdl.h so I've removed it from Requires.
The libp11-0.2.2-2 rpm builds cleanly on x86_64 and i386. This time all four
rpms {base,-devel,-debuginfo,src} have been checked with rpmlint with no
warnings or errors found.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list