[Bug 244908] Review Request: olpc-utils - various utilities used by OLPC but not packaged anywhere else

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpc-utils  - various utilities used by OLPC but not packaged anywhere else


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244908





------- Additional Comments From pertusus at free.fr  2007-06-22 19:16 EST -------
git failed:

$ git clone git://dev.laptop.org/git/projects/olpc-utils; cd olpc-utils
Initialized empty Git repository in /home/dumas/tmp/olpc-utils/.git/
fatal: The remote end hung up unexpectedly
fetch-pack from 'git://dev.laptop.org/git/projects/olpc-utils' failed.

But why don't you use
http://people.freedesktop.org/~johnp/olpc-utils-0.14.tar.bz2

on the line
make%{?_smp_mflags}
there should be a space:
config.status: creating Makefile
+ make-j3
/var/tmp/rpm-tmp.37841: line 50: make-j3: command not found
erreur: Mauvais status de sortie pour /var/tmp/rpm-tmp.37841 (%build)

rpmlint shows that a %clean section is missing:
E: olpc-utils no-cleaning-of-buildroot %clean
W: olpc-utils no-%clean-section

Since John is reading this, the following compiler warning should
be solved:
olpc-bios-sig.c: In function 'main':
olpc-bios-sig.c:35: warning: implicit declaration of function 'open'
olpc-bios-sig.c:48: warning: implicit declaration of function 'close'
olpc-bios-sig.c:58: warning: implicit declaration of function 'isdigit'

Looking at the man pages, seems to be missing:

#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <ctype.h>

Also for John, unless I am wrong configure.ac is missing, this is
not acceptable...

There is also certainly a bug somewhere (but I cannot read the
missing configure.ac...):
configure: Configuring dbench


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.