[Bug 245431] Review Request: libtommath - portable number theoretic multiple-precision integer library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtommath -  portable number theoretic multiple-precision integer library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245431





------- Additional Comments From jeremy at hinegardner.org  2007-06-23 23:31 EST -------
(In reply to comment #1)
> The web server serves that spec file as a application/octet-stream instead of
> text/plain so you can't just click and view it in a browser.

Fixed.

> The URL should be the URL of the upstream web pages describing the project
> (probably http://www.libtom.org/?page=features&newsitems=5&whatfile=ltm), not a
> pointer to the tarball.  Instead, Source0: should be the complete URL of the
> tarball.

Fixed.  Not sure why I mixed that up this time
 
> This fails to build for me:
> 
> RPM build errors:
>     File not found by glob:
> /var/tmp/libtommath-0.41-1.fc8-root-mockbuild/usr/lib64/*.so.*
>     File not found by glob:
> /var/tmp/libtommath-0.41-1.fc8-root-mockbuild/usr/lib64/*.so
> 
> It looks like the makefile puts the libraries in /usr/lib, not /usr/lib64; it
> will need to be fixed.  Unfortunately it just sets LIBPATH, but you could patch
> the makefile to wrap that in an ifndef and then pass it on the make install line.

I created a patch for makefile.shared to allow LIBPATH to be set via the environment and it being set 
via the %{_libdir} from the spec.  I do not have a x86_84 machine, so I can't test that this works 
correctly at this time.

New Spec URL: http://jeremy.hinegardner.org/fedora/libtommath/libtommath.spec
New SPRM URL: http://jeremy.hinegardner.org/fedora/libtommath/libtommath-0.41-2.fc7.src.rpm




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.