[Bug 245431] Review Request: libtommath - portable number theoretic multiple-precision integer library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtommath -  portable number theoretic multiple-precision integer library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245431





------- Additional Comments From jeremy at hinegardner.org  2007-06-26 02:38 EST -------
(In reply to comment #3)
> Some remarks.
> 
> MUSTFIX:
> 
> -  Package doesn't acknowledge RPM_OPT_FLAGS.
> makefile.shared overrides CFLAGS causing this package to be compiled with
> non-standard CFLAGS:
> E.g.:
> ... 
> libtool --mode=compile --tag=CC gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
> -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
> -mtune=generic -fasynchronous-unwind-tables -I./ -Wall -W -Wshadow
> -Wsign-compare -O3 -funroll-loops -fomit-frame-pointer   -c -o bn_mp_exch.o
> bn_mp_exch.c
> ...
> 
> The -W flags are harmless, the usefulness of -funroll-loops is arguable, 
> but -O3 and -fomit-frame-pointer should not be used in rpms.
> 
> I would suggest you to remove all -f* flags from makefile.shared or to change
> your spec file in such a way these -f*-flags are not being used.

I'll look into different ways to fix this.

> CONSIDER:
> - The package's name doesn't match the tarball name. 
> Please read: http://fedoraproject.org/wiki/Packaging/NamingGuidelines

Yes, the tarball is ltm, but the project name is libtommath, and the tarball
creates a libtommath directory.  The Guidelines say use the tarball name or the
project name.  Additionnally Gentoo, Debian, PLD distros along with OpenBSD and
FreeBSD all package libtommath as 'libtommath'.  There are other libtom*
libraries, libtomcrypt among them which I also have up for review and will use
the feedback here to help with that package.

> - The devel package installs its headers to /usr/include.
> A better design would be it to install them to a "per package header
> subdirectory" (e.g. /usr/include/tommath or similar).

I'll look into fixing this and seeing how that affects packages that depend on
libtommath too.

I'll have a new spec and srpm up in a couple of days.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.