[Bug 234612] Review Request: Ice - The Internet Communications Engine (Object middleware)
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 28 12:21:35 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Ice - The Internet Communications Engine (Object middleware)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234612
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-06-28 08:21 EST -------
Created an attachment (id=158113)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=158113&action=view)
mock build log of ice 3.2.0-4 on Fedora devel i386
Well, as this is a large srpm, it may take several (or more)
times of fixing before this package is approved...
NOTE: I am also reviewing astyle (bug 207896)
0. Review request itself
* First of all I suggest to submit a new review request
for ice-java and ice-dotnet.
(I want to review only ice package on this bug entry)
* And rename the spec name to "ice.spec".
A. Description stage
* Macros
-----------------------------------
%ifarch x86_64
%define icelibdir lib64
%else
%define icelibdir lib
%endif
-----------------------------------
- This can be replaced with %_lib macro.
- And ppc64 also uses /usr/lib64 as %_libdir,
lib64 as %_lib.
* BuildRequires
- In -ruby subpackage:
-----------------------------------
Requires: ice = %{version}, ruby(abi) = 1.8
-----------------------------------
For this, I think that BuildRequires should also have
BuildRequires: ruby(abi) = 1.8 .
B. %build stage
* optflags
- The build does not honor fedora specific optflags
(check: "Compiler flags" section of
http://fedoraproject.org/wiki/Packaging/Guidelines).
The mock build log is attached.
C. %install stage
* Timestamps
- To keep timestamps on installing files, please use
"cp -p" or "install -p" when using cp or install command
("Timestamps" section of Guildlines page)
* Macros, libdir
--------------------------------------
mkdir -p $RPM_BUILD_ROOT/usr
--------------------------------------
- Use %_prefix
--------------------------------------
mv $RPM_BUILD_ROOT/lib $RPM_BUILD_ROOT/usr/lib
--------------------------------------
- This should be %{_libdir}, not /usr/lib
* rc.init scripts
--------------------------------------
cp $RPM_BUILD_DIR/Ice-rpmbuild-%{version}/$i.%{_vendor}
$RPM_BUILD_ROOT%{_sysconfdir}/init.d/$i
--------------------------------------
- Please don't rc.init scripts into %_sysconfdir/init.d (/etc/init.d)
but instead install them under %_initrddir (=/etc/rc.d/init.d)
D. %files entry
* For main package:
---------------------------------------
%exclude %{_datadir}/Ice-%{version}/convertssl.pyo
%exclude %{_datadir}/Ice-%{version}/upgradeicegrid.pyo
%exclude %{_datadir}/Ice-%{version}/upgradeicestorm.pyo
%exclude %{_datadir}/Ice-%{version}/convertssl.pyc
%exclude %{_datadir}/Ice-%{version}/upgradeicegrid.pyc
%exclude %{_datadir}/Ice-%{version}/upgradeicestorm.pyc
---------------------------------------
- These should not be excluded.
* For scriptlets for -server subpackage
- Use: %_localstatedir for /var, %_sbindir for /usr/sbin.
NOTE: I have not installed the rpms created yet. After the issue above
are fixed, I will do further review.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list