[Bug 216322] Review Request: tailor - VCS repository conversion tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tailor - VCS repository conversion tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216322





------- Additional Comments From Jochen at herr-schmitt.de  2007-06-28 11:49 EST -------
Good:
+ Package meets naming guidlines
+ Spec file match with name of the package
+ RPM macros are used consistently
+ Package contains proper buildroot
+ Sub packages are defined properly
+ Package is llcensed on the terms of the GPL.
+ Header of source files contains references to the GPL
+ Tar ball metches with upstream
  (md5sum: 82033c16e895d51ae5893def06c59d29)
+ Package contains proper %defattr and file permissions
+ Filelist contains no duplicated entry
+ Package contains no files or directory own by other packages
+ %doc section is small
+ %doc section doen't affect runtime
+ Package contains proper %clean section
+ Buildroot will clean on the beginning of the %install section
+ Local build works fine.
+ Changelog section looks ok
+ Rpmlint is quite on source package
+ Mock build works fine for Devel and F-7 (x86_64)

Bad:
- Package doesn't contains verbatim copy of the license text
  (Please ask upstream to include a copy of the GPL license text)
- Rpmlint complaints python-vcpx package:
E: python-vcpx non-executable-script
/usr/lib/python2.5/site-packages/vcpx/repository/p4/p4lib.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

You should remove the shebang line from the file complaint by Rpmlint.

 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.