[Bug 225765] Merge Review: fonts-japanese

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 1 13:15:24 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: fonts-japanese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225765





------- Additional Comments From tagoh at redhat.com  2007-03-01 08:15 EST -------
(In reply to comment #1)
> W: fonts-japanese no-url-tag
> The URL tag is missing.

It's hard to write down in URL tag because this packages includes a lot of fonts
that shipped on the different places. I mean, it's not a vendor-specific
package, but just collection.

> W: fonts-japanese unversioned-explicit-obsoletes ttfonts-ja

Fixed.

> W: fonts-japanese unversioned-explicit-obsoletes jisksp14

Fixed.

> W: fonts-japanese unversioned-explicit-obsoletes jisksp16-1990

Fixed.

> W: fonts-japanese unversioned-explicit-obsoletes kappa20

Fixed.

> W: fonts-japanese unversioned-explicit-obsoletes knm_new

Fixed.

> W: fonts-japanese unversioned-explicit-obsoletes fonts-ja

Fixed.

> W: fonts-japanese rpm-buildroot-usage %build %configure --disable-bold
> --disable-italic --with-fontdir=$RPM_BUILD_ROOT%{bmpfontdir}
> $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
> will break short circuiting.

Actually that line doesn't break anything. just lazy workaround to install the
font files under the proper place to be packaged, without any patches to
Makefile and extra parameters to make because DESTDIR isn't helpful since it
doesn't use automake.

> W: fonts-japanese mixed-use-of-spaces-and-tabs (spaces: line 40, tab: line 1)
> The specfile mixes use of spaces and tabs for indentation, which is a
> cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

Fixed.

> E: fonts-japanese obsolete-not-provided ttfonts-ja

Fixed.

> E: fonts-japanese obsolete-not-provided jisksp14

Fixed.

> E: fonts-japanese obsolete-not-provided jisksp16-1990

Fixed.

> E: fonts-japanese obsolete-not-provided kappa20

Fixed.

> E: fonts-japanese obsolete-not-provided knm_new

Fixed.

> E: fonts-japanese obsolete-not-provided fonts-ja

Fixed.

> E: fonts-japanese file-in-usr-marked-as-conffile

Waiting for the conclusion on the list

> E: fonts-japanese file-in-usr-marked-as-conffile

Likewise.

> W: fonts-japanese non-conffile-in-etc /etc/ghostscript/CIDFnmap.ja

Fixed.

> W: fonts-japanese non-conffile-in-etc /etc/ghostscript/cidfmap.ja

Fixed.

> W: fonts-japanese non-conffile-in-etc /etc/ghostscript/FAPIcidfmap.ja

Fixed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list