[Bug 230560] Review Request: wqy-bitmapfont - a fine-tuned CJK bitmap font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wqy-bitmapfont - a fine-tuned CJK bitmap font


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230560





------- Additional Comments From ingvar at linpro.no  2007-03-01 15:02 EST -------
Since this is your first submission, you probably need a sponsor. You
should ask for one here, and mark the bugzilla ticket as blocking
FE-NEEDSPONSOR, see
http://fedoraproject.org/wiki/Extras/HowToGetSponsored for details.

According to the specfile, the upstream source should be available at
http://downloads.sourceforge.net/wqy/wqy-bitmapfont-pcf-0.8.0-6.tar.gz. I
can't find it there. The upstream source tarball must be available for
download, and match the tarball in the src.rpm.

The specfile:

* You lack an url tag. You should add an URL tag pointing to the main
  page of the project.

* The version and release tags doesn't match the latest changelog
  item.

* The package obsoletes an earlier version of itself. This is
  uneccessary, and may lead to strange problems. rpm will upgrade the
  package correctly without this.

* The package uses chkfontpath without adding it as a
  requirement. Parts of the %post scriptlet tests if chkfontpath is
  installed. It would be simpler to just make sure it is installed by
  adding it as a requirement. If chkfontpath is not installed, The
  %post scriptlet also edits xorg.conf, adding the needed. fontpaths.
  I find this way too intrusive. Just make sure chkfontpath is
  installed.

* The %preun scriptlet is a bit too aggressive too, at least in my
  eyes, deleting and moving files around, and editing xorg.conf. I am
  no font expert, but I thought chkfontpath and its relatives was made
  to avoid such hacks.

The rpm builds without errors on my fc6 system.

rpmlint outputs:

$ rpmlint wqy-bitmapfont-0.8.0-6.src.rpm 
W: wqy-bitmapfont no-url-tag
W: wqy-bitmapfont strange-permission wqy-bitmapfont.spec 0600

This is probably because you have built the source rpm from at tarball with the
specfile built-in. Copy the sources to /path/to/rpm/SOURCES, and the specfile to
/path/to/rpm/SPECS, and do a rpmbuild -bs on the specfile.

W: wqy-bitmapfont mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 59)

This one is easy :-)

$ rpmlint wqy-bitmapfont-0.8.0-6.noarch.rpm 
W: wqy-bitmapfont incoherent-version-in-changelog 0.8.0 0.8.0-6
W: wqy-bitmapfont no-url-tag
E: wqy-bitmapfont obsolete-on-name
W: wqy-bitmapfont dangerous-command-in-%post cp
E: wqy-bitmapfont no-prereq-on chkfontpath
W: wqy-bitmapfont dangerous-command-in-%preun rm
E: wqy-bitmapfont no-prereq-on chkfontpath


Keep on the good work!

Ingvar

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.