[Bug 218556] Review Request: ecryptfs-utils - Linux eCryptfs utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ecryptfs-utils - Linux eCryptfs utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218556





------- Additional Comments From mhalcrow at us.ibm.com  2007-03-01 18:14 EST -------
Kevin Fenzi (kevin at tummy.com) wrote:
> 1. Might include the following as %doc files:
> AUTHORS NEWS THANKS

Done.

> On point 2, you might consider litterally having:
> Requires: %{name} = %{version}-%{release}
> in the spec.

Done.

> So, the module wasn't loaded and it didn't autoload it. 
> I did a manual 'modprobe ecryptfs' and then tried again. 
> It seems to work, but I don't see anything with df, and looking in 
> dmesg I get: 
>
> mount.ecryptfs[4322] general protection rip:3226c5e4b9
> rsp:7fffa5c67a80 error:0
> mount.ecryptfs[4568] general protection rip:3226c5e4b9
> rsp:7fff15962c10 error:0

There was a bug in the error path (free bogus pointer). Fixed in the
ecryptfs-utils-10 release.

Peter Vrabec (pvrabec at redhat.com) wrote:
> There are 2 lines before kernel error in messages:
> Mar 1 11:33:47 rawhide64 mount.ecryptfs: Your kernel does not
> support key module [openssl]
> Mar  1 11:33:59 rawhide64 mount.ecryptfs: Mount opts: 
> [ecryptfs_sig=945f0e28ae2dfba0,ecryptfs_key_bytes=16,ecryptfs_cipher=aes,]

The mount helper is overly verbose; fixed in the ecryptfs-utils-10
release.

I also changed the key module build in ecryptfs-utils-10 so that it is
now possible to disable building the OpenSSL key module; however, that
should not affect the RPM. Future releases will likely include many
more key modules, and if they are all included in the same RPM, then
there could be an extra dependency for each key module (openCryptoki,
TrouSerS, etc.), whether the user wants the key module or not. If it
would be acceptable to break the key modules into individual RPM's
(ecryptfs-keymodule-openssl, ecryptfs-keymodule-tss,
ecryptfs-keymodule-ock, etc.), then that would reduce the dependencies
for ecryptfs-utils.

Updated SPEC is here:
http://downloads.sourceforge.net/ecryptfs/ecryptfs-utils.spec?use_mirror=osdn

Updated SRPM is here:
http://downloads.sourceforge.net/ecryptfs/ecryptfs-utils-10-0.src.rpm

There are also a number of minor kernel bugfixes that Red Hat may want to pick
up as separate patches in its 2.6.20 kernel.

Mike

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.