[Bug 225909] Merge Review: iputils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: iputils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225909


mildew at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mildew at gmail.com




------- Additional Comments From mildew at gmail.com  2007-03-02 20:03 EST -------
(!!) MUST: rpmlint output:
**** Review message:
W: iputils no-url-tag
   - URL tag is missing, should be: http://www.tux.org/pub/net/ip-routing/
W: iputils redundant-prefix-tag
   - Line: 35 "Prefix: %{_prefix}" should be removed.
W: iputils buildprereq-use docbook-utils perl-SGMLSpm
W: iputils buildprereq-use glibc-kernheaders >= 2.4-8.19
W: iputils prereq-use chkconfig
W: iputils macro-in-%changelog files
   - Line: 404 - List /usr/sbin/rdisc in %files list.
     Should be: %%files
W: iputils mixed-use-of-spaces-and-tabs (spaces: line 131, tab: line 92)

********************
(!!) MUST: The package must meet the Packaging Guidelines.
**** Review message:
- Uses BuildPreReq instead of BuildRequires.
- Uses PreReq instead of Requires.
- BuildRoot: %{_tmppath}/%{name}-root
  Required value is: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

********************
(!!) SHOULD: Packager should query upstream for license text file.
**** Review message:
- License file is missing.
- Missing file "README.bonding" listed in %doc.
********************

(Sorry for the late answer)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.