[Bug 229154] Review Request: konwert - Converter of character encodings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: konwert - Converter of character encodings


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229154





------- Additional Comments From lxtnow at gmail.com  2007-03-02 21:03 EST -------
OK - Mock Build on FC-6 FC-Devel (i386,x86_64)
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License is GPL
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum for both:
0a1dcb0fa7a1990980aba8ab9a4c3184  konwert-1.8.tar.gz
962c3d339b99656bb37a25c39d7d3dca  konwert-forbids_data_member.patch
OK - Package has correct buildroot.
OK - BuildRequires isn't required.
OK - Subpackage -devel is present.
OK - %prep stage is correct and work.
OK - The use of iconv is proper.
OK - %build and %install stages is correct and work.
OK - No *.la files is present in -devel subpackage.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - rpmlint output are clean.

OK - Should function as described.
OK - Should package latest version
OK - Should have %{?dist} tag but, should be remove to avoid trouble in CVS
import/Update/Build procedure.





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.