[Bug 226237] Merge Review: pcmciautils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pcmciautils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226237





------- Additional Comments From ville.skytta at iki.fi  2007-03-03 07:13 EST -------
Doesn't use $RPM_OPT_FLAGS.  A simple fix is to do 'make
OPTIMIZATION="$RPM_OPT_FLAGS"' instead of 'make' in %build but that trumps the
upstream -Os vs -O2 selection.  Not a big deal, I think, but if there's a
compelling reason to use -Os, pcmciautils-fedora.patch could be changed to do
this in order to preserve it:
CFLAGS += $(RPM_OPT_FLAGS) $(OPTIMIZATION) -D_GNU_SOURCE

URL tag missing, a suitable one could be eg.
http://www.kernel.org/pub/linux/utils/kernel/pcmcia/pcmcia.html

Are the pcmcia-cs and kernel-pcmcia-cs Obsoletes still needed?  If no, drop; if
yes, should be made versioned.

No PCMCIA hardware here so I'll leave rest of the review to someone else.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.