[Bug 226813] Merge Review: zsh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zsh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226813





------- Additional Comments From kevin at tummy.com  2007-03-04 00:45 EST -------
ok, buildroot is now fine. 

>  The functions are supposed to be sourced, so they don't need to be executable.

ok, but then do they need the #!/bin/zsh at the top of each file if they aren't
going to be executed? 

rpmlint says now:

(the non executable script errors from before)

1.E: zsh use-of-RPM_SOURCE_DIR

You use that in the following construct: 

for i in zshrc zlogin zlogout zshenv zprofile; do
    install -m 644 $RPM_SOURCE_DIR/${i}.rhs ${RPM_BUILD_ROOT}%{_sysconfdir}/$i
done

Can't RPM_SOURCE_DIR just be removed from that? The install section should 
be run with a current working dir of the top of the source dir I think...

2. W: zsh mixed-use-of-spaces-and-tabs (spaces: line 72, tab: line 108)

Only a nitpick. Remove if you like while making other changes. 

3. W: zsh patch-not-applied Patch1: zsh-4.0.6-make-test-fail.patch

Remove old patch? 

4. W: zsh prereq-use fileutils grep /sbin/install-info

Those Requires you added shouldn't be needed. You should remove the Requires:
line you added in -5, and also remove the Prereq: line. 
Replacing it with: 

Requires(post): /sbin/install-info
Requires(preun): /sbin/install-info

5. One thing I just noticed that I missed. You should not be using 
%makeinstall if you can avoid it. Can you use 'make DESTDIR=$RPM_BUILD_ROOT
install' instead? 

Thanks for the quick fixes!





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.