[Bug 230738] Review Request - jwm - Very light window manager

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 4 15:45:26 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request - jwm - Very light window manager
Alias: jwm

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230738


aportal at univ-montp2.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aportal at univ-montp2.fr




------- Additional Comments From aportal at univ-montp2.fr  2007-03-04 10:45 EST -------
Sorry, I can't sponsor you.
This isn't a full review, I just found some thing you have to fix.

BuildRequires: libX11 isn't needed

jwm doesn't honor $RPM_OPT_FLAGS, which means it's built without any compiler
provided security features and other distro wide CFLAGS.

Also, the debuginfo package is useless because the binary is explicitly 
stripped.

One way to fix these issues is to add these after %configure:
sed -i -e 's/^\(CFLAGS.*\)/\1 $(RPM_OPT_FLAGS)/' src/Makefile
sed -i -e '/^\s*strip /d' src/Makefile



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list