[Bug 225235] Merge Review: a2ps

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 4 21:27:45 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: a2ps


------- Additional Comments From pertusus at free.fr  2007-03-04 16:27 EST -------
In my opinion the autotools issue is a must fix, particularly
since I did a patch.

E: a2ps file-in-usr-marked-as-conffile /usr/share/a2ps/afm/fonts.map
it is clearly wrong in my opinion. There are many ways to override
the defaults. Moreover there is no reason to have that file as %config,
and not, say, encoding.map.

In my opinion what should be done would be to add, in
a2ps-4.13-etc.patch,  $(sysconfdir)/$(PACKAGE) on the
libpath line, in etc/Makefile.in and etc/Makefile.am.
and add %dir %{_sysconfdir}/a2ps to %files.

I can do a patch if desired (and after the auto* issue is solved)

Other issues:

gzip %{buildroot}%{_infodir}/* || :
  is unneeded

* %{_sysconfdir}/a2ps.cfg shouldn't be (noreplace) and I even think
that it shouldn't be %config at all.

* missing BuildRequires psutils, gv, tetex-dvips, makeinfo,
Missing Requires ImageMagick, texinfo-tex, gv, gzip,
  bzip2,  groff-perl, tetex-dvips, tetex-latex, tetex-fonts

* for consistency use the info scriptlets from 
and also remove the .gz.

* use %defattr(-,root,root,-)

* use sed instead of perl for simple substitution

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the package-review mailing list