[Bug 226529] Merge Review: vixie-cron

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: vixie-cron


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226529





------- Additional Comments From pertusus at free.fr  2007-03-05 07:00 EST -------
Instead of checking subsys, you could use the standard scriptlet.
It will be safer, too.

if [ $1 = 0 ]; then
        /sbin/service <script> stop >/dev/null 2>&1 || :
        /sbin/chkconfig --del <script>
fi

http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-97754e2c646616c5f6222f0cfc6923c60765133e

Similar for the postun scriptlet.

Regarding the Requires(...) in my opinion it should be along:

Requires(post): /sbin/chkconfig coreutils
Requires(postun): /sbin/chkconfig /sbin/service
Requires(preun): /sbin/chkconfig /sbin/service


There are still places in %files and one in install 
where %{_sysconfdir} should be uses, also %_sbindir in %files.
 
RPM_OPT_FLAGS="$RPM_OPT_FLAGS
seems dubious to me. I guess it comes from a patch. I'll review them
later.


If I'm not wrong this package seems not to have any upstream.
Is there a collaboration between linux distro package maintainers, and 
BSD maintainers to share patches and things like that?


A suggestion (a personal preference):
For install call, I always add -mxxx to show clearly the permission
of installed files.
For that reason I prefer install over cp.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.