[Bug 229910] Review Request: Conmux - Console Multiplexor, abstracts how to connect via backend drivers.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Conmux - Console Multiplexor, abstracts how to connect via backend drivers.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229910





------- Additional Comments From wolfy at nobugconsulting.ro  2007-03-05 15:23 EST -------
Quick glance:
- GOOD: package builds fine in mock/devel/x86_64
- estethic :
[wolfy at wolfy conmux]$ rpmlint conmux-0-1.493svn.fc7.src.rpm
W: conmux mixed-use-of-spaces-and-tabs (spaces: line 21, tab: line 1)
The fix is obvious...
- MUSTFIX:
rpmlint conmux-0-1.493svn.fc7.noarch.rpm
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/text-base/README.svn-base
W: conmux hidden-file-or-dir /usr/share/doc/conmux-0/examples/.svn
W: conmux hidden-file-or-dir /usr/share/doc/conmux-0/examples/.svn
E: conmux version-control-internal-file /usr/share/doc/conmux-0/examples/.svn/props
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/prop-base/direct.cf.svn-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/tmp/prop-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/text-base/command.cf.svn-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/prop-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/text-base/socket.cf.svn-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/prop-base/socket.cf.svn-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/text-base/direct.cf.svn-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/tmp/text-base
E: conmux version-control-internal-file /usr/share/doc/conmux-0/examples/.svn/format
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/tmp/props
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/prop-base/command.cf.svn-base
E: conmux version-control-internal-file /usr/share/doc/conmux-0/examples/.svn/tmp
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/prop-base/README.svn-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/text-base
E: conmux version-control-internal-file
/usr/share/doc/conmux-0/examples/.svn/entries

Since there are a couple of other useless .svn directories, I suggest using
something similar to " find /path -name .svn -type d -exec rm -fR {} \;" in
order to remove all of them.
- other messages from rpmlint:
W: conmux no-reload-entry /etc/init.d/conmux
This one can be ignored

E: conmux subsys-not-used /etc/init.d/conmux
I admit I cannot figure out why does rpmlint complain here

- rpmlint warns about no docs in -common and -client. Those can be safely ignored.

- The name of the doc folder is "/usr/share/doc/conmux-0". Is the ending "-0"
really intended? If yes, why? If not...
- Timestamps of the scripts (init.d / logrotate) are not preserved at install
time. Usually adding INSTALL="%{__install} -p" to "make install" fixes that.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.