[Bug 230512] Review Request: viewvc- Browser interface for CVS and SVN version control repositories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: viewvc-  Browser interface for CVS and SVN version control repositories


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230512





------- Additional Comments From bjohnson at symetrix.com  2007-03-05 19:17 EST -------
In viewvc.conf:
> # Use CvsGraph. See http://www.akhphd.au.dk/~bertho/cvsgraph/ for
> # documentation and download.
> #
> use_cvsgraph = 0

package required but not used.

(In reply to comment #36)
> In relation to +x, if I don't do that to any file that has #! in th first line,
> rpmlint won't like it. So, it should stay, I guess.

> # mod_python files do not have to be executable (make rpmlint happy)
> %{__chmod} 0644 %{buildroot}%{python_sitelib}/viewvc/bin/mod_python/*.py

Ah, now I see.  After some additional investigation... this appears to be a
minor bug in their install script.  It sets the +x although that is not needed
for mod_python, and because there is no shebang, then rpmlint gets angry.  Ok, I
got it now.

You might want to feed this back upstream.

You probably want to notate that in the spec file as well so others don't wonder
why.


License:
compat_difflib.py: No license, assumed BSD or PSF ?
compat_ndiff.py: Public Domain - ok
py2html.py: eGenix.com Public License - ?
PyFontify.py: No license, assumed BSD ?
 
I *think* these are all ok.


Did you intend to do any updates based on Paul's comment #39?



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.