[Bug 226813] Merge Review: zsh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zsh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226813





------- Additional Comments From kevin at tummy.com  2007-03-05 20:56 EST -------
In reply to comment #8: 

> They don't need it, I regard that as a comment saying "this is designed to work
>with zsh". I could remove the comment, or more likely make the files executable
>just to silence the warning ... I guess. It's kind of hacky but maybe the least
>resistence solution.

Well, I can see it causing confusion for the end user... "hey, this is a script,
I should run it." "what do you mean, Permission Denied?"

> I looked at this, IMNSHO rpmlint needs to be fixed for this. The tab is in a
>string which is output, removing that would be very bad. I thought about
>changing it to use \t ... but I'd rather not change it at all, and rpmlint is
>certainly the wrong one here.

Agreed. ;( 

> Is there policy text anywhere about why doing the dep. on /sbin/install-info
>is the right approach?

Well, nothing set in stone, but they are used in: 
 http://www.fedoraproject.org/wiki/Packaging/ScriptletSnippets
and it seems to make sense to me... whats the alternative? texinfo package?

>Dito. %makeinstall ... I'd just like to know (and have it documented here) why
>that should change.

Yeah, totally understandable. 
http://www.fedoraproject.org/wiki/PackagingDrafts/MakeInstall
http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002

%makeinstall is acceptable only when the 'make DESTDIR=...' syntax doesn't work
with a package. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.