[Bug 230831] Review Request: games-menus - Catagorized submenus for the GNOME/KDE Games menu
bugzilla at redhat.com
bugzilla at redhat.com
Wed Mar 7 17:25:54 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: games-menus - Catagorized submenus for the GNOME/KDE Games menu
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230831
mr.ecik at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
AssignedTo|nobody at fedoraproject.org |mr.ecik at gmail.com
Flag| |fedora-review?,
| |needinfo?(j.w.r.degoede at hhs.
| |nl)
------- Additional Comments From mr.ecik at gmail.com 2007-03-07 12:25 EST -------
REVIEW
** Tarball contains license text so include it into package
** Package should require hicolor-icon-theme or own %{_datadir}/icons/hicolor
** rpmlint louds:
W: games-menus no-documentation
W: games-menus non-conffile-in-etc /etc/xdg/menus/applications-merged/games-
categories.menu
Apart from COPYING, you can also include one of your last fedora-games-list
mails as a README (but only a license is MUST)
We can safely omit the second warning.
And the things I've written about before. Change URL tag, own %{_datadir}/
desktop-directories etc.
Also, if "sources" aren't available anywhere, add a comment that we're an
upstream to clarify things.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list