[Bug 194280] Review Request: kdebindings: KDE/DCOP bindings to non-C++ languages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdebindings: KDE/DCOP bindings to non-C++ languages


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194280





------- Additional Comments From kevin at tummy.com  2007-03-07 14:57 EST -------

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs

1. The dcopperl subpackage, you need to move the
BuildRequires: perl
above the description. Right now that shows up in the description.
Since perl is in the min build root, do we need this? 
(Although I think it's currently only there due to rpm-build needing it)

2. rpmlint says:

a)
E: kdebindings non-executable-script /usr/share/apps/kjsembed/cmdline.js 0644

Should this be 755? Not sure if there is any need for javascript to be exectable tho

b)
E: kdebindings hardcoded-library-path in %{_prefix}/lib/jvm/java-1.4.2

Remove prefix here?

c)
W: kdebindings mixed-use-of-spaces-and-tabs (spaces: line 69, tab: line 5)

Minor nit, fix if you like.

d)
W: kdebindings patch-not-applied Patch140302: kdebindings-3.5.6-kde#140302.patch

Drop patch if it's not applied?

e)
E: kdebindings-dcopperl non-standard-executable-perm
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/DCOP/DCOP.so 0555

Should be 755?

f)
W: kdebindings-devel no-documentation

ignore.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.