[Bug 226390] Merge Review: scim-anthy

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 9 08:11:04 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: scim-anthy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226390





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-09 03:11 EST -------
Created an attachment (id=149671)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149671&action=view)
mock build log of scim-anthy-1.2.2-1 on FC-devel i386

Merge review for scim-anthy 1.2.2-1

* URL
  Umm.. Is http://scim-imengine.sourceforge.jp/ hijached??
  
* Source URL
  - Source URL must be where we can directly download the source
    by "wget -N", for example.
    Currently Source0 points to only a HTML.

* Rebuild
  - Mock build fails (on FC-devel i386).
    * Note: making autoconf called after configure is done must
      be avoided.

* rpmlint
  A. For srpm:
----------------------------------------------------
A-1 W: scim-anthy mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 5)
----------------------------------------------------
     A-1 Minor issue, however, it is recommended to fix this.

  B. For binary rpm
----------------------------------------------------
B-1 E: scim-anthy obsolete-not-provided iiimf-le-canna
B-2 E: scim-anthy zero-length /usr/share/doc/scim-anthy-1.2.2/TODO
----------------------------------------------------
     B-1 _should_ be ignored IMO, because scim-anthy does not
	 actually provide iiimf
     B-2 would you explain why you want to include this empty file?

* Directory ownership
  - The following directories are owned by other packages
    required by this package.
----------------------------------------------------
/usr/share/scim  - by scim
/usr/share/scim/icons - by scim
----------------------------------------------------

* Timestamps
  - This package contains some 
    * text files (such as "*.sty")
    * image files (such as "*.png)
    and keeping timestamps on these files are recommended.
    Generally, 
----------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
----------------------------------------------------
    works (however currently I cannot test this because
    mockbuild fails as attached)    

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list