[Bug 229676] Review Request: gle - Graphics Layout Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gle - Graphics Layout Engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229676





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-10 13:21 EST -------
Well, for gle-4.0.12-2:

* Encoding
  - Well, you tried to change LICENSE.txt to UNIX format by dos2unix,
    however, it is not enough.
---------------------------------------------------
[tasaka1 at localhost gle]$ file /usr/share/doc/gle-4.0.12/LICENSE.txt
/usr/share/doc/gle-4.0.12/LICENSE.txt: data
---------------------------------------------------
    Well, emacs with hexl-mode shows that this document has
    a strange '0x13' code (note: Windows CR code is '0x0d').
    Please remove both.

* Conditional dependency
  - Mockbuild log says:
---------------------------------------------------
checking for XOpenDisplay in -lX11... no
.....
   ** X11 preview support: no
---------------------------------------------------
    Please fix configure (NOTE: not configure.in but
    configure. Please don't use autotool as much as
    possible) (around the line 2709).

* Timestamps
  - This package tries to install some files from original
    zip file without any modification, such as
---------------------------------------------------
./src/manip/manip.hlp
./src/fonts/font.dat
./src/fonts/psfont.dat
./src/lib/*.gle
./src/TeX/init.tex
---------------------------------------------------
   , and keeping timestamps on these files are recommended.
   Please fix the line of build log such as
---------------------------------------------------
mkdir -p ../../build/font
cp *.fve *.fmt ../../build/font
cp font.dat ../../build/font
cp psfont.dat ../../build/font
touch movefonts
make[1]: Leaving directory `/builddir/build/BUILD/gle4/src/fonts'
make -C src/lib -f Makefile.gcc
make[1]: Entering directory `/builddir/build/BUILD/gle4/src/lib'
mkdir -p ../../build/lib
cp *.gle ../../build/lib/
make[1]: Leaving directory `/builddir/build/BUILD/gle4/src/lib'
make -C src/TeX
make[1]: Entering directory `/builddir/build/BUILD/gle4/src/TeX'
cp init.tex ../../build/
../../build/bin/gle -mkinittex
---------------------------------------------------
   to:
---------------------------------------------------
cp -p *.fve *.fmt ../../build/font
cp -p font.dat ../../build/font
cp -p psfont.dat ../../build/font
.....
---------------------------------------------------
  for example.

* rpmlint
  - not silent.
---------------------------------------------------
E: gle-debuginfo script-without-shebang /usr/src/debug/gle4/src/manip/unix_extra.cpp
W: gle-debuginfo spurious-executable-perm
/usr/src/debug/gle4/src/gle/tokens/CharBitMap.h
W: gle-debuginfo spurious-executable-perm
/usr/src/debug/gle4/src/gle/surface/gsurface.h
W: gle-debuginfo spurious-executable-perm /usr/src/debug/gle4/src/gle/surface/f2c.h
E: gle-debuginfo script-without-shebang /usr/src/debug/gle4/src/gle/letzfitz/let.cpp
W: gle-debuginfo spurious-executable-perm /usr/src/debug/gle4/src/manip/ffblk_def.h
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/tokens/Tokenizer.cpp
W: gle-debuginfo spurious-executable-perm
/usr/src/debug/gle4/src/gle/tokens/Tokenizer.h
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/surface/fcontour.cpp
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/surface/gsurface.cpp
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/surface/ffitcontour.cpp
E: gle-debuginfo script-without-shebang /usr/src/debug/gle4/src/manip/unixscr.cpp
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/surface/vdevice.cpp
E: gle-debuginfo script-without-shebang /usr/src/debug/gle4/src/gle/surface/hide.cpp
E: gle-debuginfo script-without-shebang /usr/src/debug/gle4/src/gle/tokens/BinIO.cpp
W: gle-debuginfo spurious-executable-perm
/usr/src/debug/gle4/src/gle/tokens/StringKeyHash.h
W: gle-debuginfo spurious-executable-perm /usr/src/debug/gle4/src/gle/tokens/BinIO.h
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/tokens/StringKeyHash.cpp
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/surface/gcontour.cpp
E: gle-debuginfo script-without-shebang
/usr/src/debug/gle4/src/gle/tokens/Tokenizer.i
E: gle-debuginfo script-without-shebang /usr/src/debug/gle4/src/manip/unixinkey.cpp
E: gle-debuginfo script-without-shebang /usr/src/debug/gle4/src/manip/varargs.cpp
-----------------------------------------------------
    - Perhaps all permission issue. Please fix the permission to 0644.

* License
  - Some files are not licensed under BSD.
    A. GPL
------------------------------------------------------
./src/gui/about.*
./src/gui/arc.*
( and many other files under ./src/gui )
------------------------------------------------------
   B. assumely GPL (however, would you contact upstream?)
------------------------------------------------------
./src/gui/gsinc/gdevdsp.h
( and some other files under ./src/gui/gsinc )
------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.