[Bug 230250] Review Request: gtkhtml38 - GtkHTML 3.8 compatibility library & devel bits

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkhtml38 - GtkHTML 3.8 compatibility library & devel bits


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230250


maxx at krakoa.dk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |maxx at krakoa.dk
OtherBugsDependingO|                            |188267
              nThis|                            |




------- Additional Comments From maxx at krakoa.dk  2007-03-10 17:27 EST -------
rpmlint gives the following output:

W: gtkhtml38-devel no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

Which in this case is fine anyway since I couldn't find any documentation in the
source package that could have been included.

Package name and spec file name are fine.

License is fine and included in the package.

Source file matches upstream.

Package compiles and builds on x86.

Build dependencies listed correctly in BuildRequires.

.so files split up correctly between main package and devel package.

no .la files.

-devel requires base package correctly.

package cleanup is fine.

So everything is basically fine.


However one small error is the line trying to delete a .servere file.

rm -f $RPM_BUILD_ROOT%{_libdir}/bonobo/servers/GNOME_GtkHTML_Editor-3.8.servere

That should be

rm -f $RPM_BUILD_ROOT%{_libdir}/bonobo/servers/GNOME_GtkHTML_Editor-3.8.server

And it might be nice with a small note in spec file explaining why the .server
file is being deleted. I am assuming it is because you want this package just to
provide the old libs and not the old bonobo components?

If you fix these small things I'll ACCEPT the package. By the way this will be
first formal package review so I hope I am doing it correctly.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.