[Bug 231746] Review Request: ettercap - Network traffic sniffer/analyser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ettercap - Network traffic sniffer/analyser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231746





------- Additional Comments From opensource at till.name  2007-03-11 18:07 EST -------
(In reply to comment #7)
> So should only /usr/sbin/ettercap be in ettercap and ettercap-gtk and the rest
> in ettercap-common?

This sounds to me to be the best way.

(In reply to comment #8)
> I've got the above finished, but no matter how I compile, the resulting binary
> still requires a choice of interface set at the command line, -T, -C, or -G.  Is
> this a candidate for Alternates, and if so how would that work?

Alternatives would not help here. This helps only, when you may install several
packages, that contain e.g. a binary with the same name but different code. The
choice of interface is something that has to be changed in the source code of
ettercap, if you want to change it. A simple patch to the ec_parser.c file would
do it and a simple patch for ettercap.1.in to show that the -G option only works
with the -gtk package. I will attach a patch that selects the UI depending on
whether ettercap was invoked as ettercap-{text,gtk,curses} and demanding a UI
option when invoked as ettercap. The patch also makes ettercap display a warning
when someone wants to use "-G" and gtk support is not supported (same for
curses) and the display text only displays the supported options. Also in the
right places I changed GUI to UI in the help text. Maybe upstream agrees with
this patch, too.

The different packages help only to install ettercap without having to install
the gtk dependencies. 

In the gtk subpackage, there should also be a .desktop file and the regarding
scriptlets, I just realized.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.