[Bug 226529] Merge Review: vixie-cron

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: vixie-cron


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226529





------- Additional Comments From pertusus at free.fr  2007-03-12 09:12 EST -------
(In reply to comment #17)
> comment #13 
> > install -pm755 %{SOURCE1} $RPM_BUILD_ROOT/etc/rc.d/init.d/crond
> How could I replace $RPM_BUILD_ROOT/etc -> with %_sysconfdir = /usr/etc ?

If you are meaning that you don't want to use %_sysconfdir because
you find it better to hardcode etc since it is where the init system
will search, then ok for me. May deserve a comment in the spec file.
If you want to say something else I haven't understood.

Anyway there are other places where /etc or /var are hardcoded.

> comment #14
> > upstream
> Could you tell me where find upstream, which you've meant?

I haven't meant that there was an upstream. In fact I told the reverse.
It seems to me that upstream is not active anymore. So it also seems to
me that a collaboration between the linux and bsd distros maintainers
could help reducing the double work and improve the testing of new
patches. did you approach other maintainers?

> > option
> You can change makefile or spec file, I decided to change spec.

I don't really understand your comment but if this is about my suggestion,
since it is only a suggestion, it's ok.

> comment #15
> It's possibility to rebuild package and change version. But I want to do it
> after some more work on cron.

> If you want review patches, it's ok, but I think reviewing selinux patches would
> be time consuming.

I don't want to review the the code in patches, but I want you to 
clean them up such that they are indeed reviewable.

For an example of what is not acceptable, I will take the example of the
vixie-cron-4.1.pam/crond.pam file. It is created in
vixie-cron-4.1-_14_pamd_crond.patch
and then changed in 
vixie-cron-4.1-_50-bz178931.patch
vixie-cron-4.1-_56-pam-session-system-auth.patch
vixie-cron-4.1-loginuid.patch

This isn't acceptable. I can see 2 possibilities
* if vixie-cron-4.1-_14_pamd_crond.patch is available somewhere on the 
  internet the patch from internet should be used, and then there could
  be another patch.
* otherwise the file should be created only at one place


I ask you to change the patches such that each file is changed only in 
one patch, and that patches are grouped by features. If you don't see
which patches are problematic I could tell you more precisely, but maybe 
you could begin some cleanings, and I'll recheck after. 

If you really don't have an idea on what you have to do, I can try to
analyse the patches to give you more specific directions.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.