[Bug 226320] Merge Review: psacct

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: psacct


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226320


mmaslano at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
               Flag|                            |needinfo?(varekova at redhat.co
                   |                            |m)




------- Additional Comments From mmaslano at redhat.com  2007-03-12 11:25 EST -------
SRC
W: psacct no-url-tag
W: psacct strange-permission psacct.init 0775
W: psacct prereq-use /sbin/chkconfig /sbin/install-info
ARCH
W: psacct no-url-tag
W: psacct conffile-without-noreplace-flag /var/account/pacct
E: psacct non-readable /var/account/pacct 0600
W: psacct dangerous-command-in-%post mv

Replace buildroot.
Prereq  should be with post, pre, ...
Replace macro %{makeinstall}, if you can.
Defattr has 4 parametres.

mkdir -p $RPM_BUILD_ROOT{/sbin,%{_bindir},%{_mandir},%{_sbindir}}
Isn't $RPM_BUILD_ROOT/sbin the same as $RPM_BUILD_ROOT/%{_sbindir} ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.