[Bug 229676] Review Request: gle - Graphics Layout Engine

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 12 17:50:24 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gle - Graphics Layout Engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229676





------- Additional Comments From terjeros at phys.ntnu.no  2007-03-12 13:50 EST -------
> * Timestamps
>   - Still some "cp" command does not keep timestamps
>     Perhaps in some cases you have to make a patch against
>     Makefile.in, not Makefile

This seems a bit off for me, most of these files are generated during 
build. I am dropping the preserve timestamps patch for now,
I can't see this as a blocker. Where is this policy coming from anyway?

> * For license

I will send a email upstream.

> * Conditional dependency
>   - Build log still says:
> --------------------------------------
>    ** X11 preview support: no
>
> config.log says:
>-------------------------------
>   235	configure:2478: checking for X
>   245	g++: argument to '-L' missing

Seems like configure want explicit x flags, I tried to fix by adding:

 --x-includes=%{_includedir}/X11 --x-libraries=%{_libdir}

Better now?

Spec:
  http://web.phys.ntnu.no/~terjeros/gle/gle.spec
SRPM:
  http://web.phys.ntnu.no/~terjeros/gle/gle-4.0.12-3.fc6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list