[Bug 189949] Review Request: mystun - STUN (Simple Traversal of UDP through NATs) server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mystun - STUN (Simple Traversal of UDP through NATs) server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189949


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776                      |163778
              nThis|                            |
               Flag|                            |fedora-review?




------- Additional Comments From wolfy at nobugconsulting.ro  2007-03-12 22:37 EST -------
Good:

- rpmlint checks return:
on source
W: mystun strange-permission mystun.init 0755
->can be ignored, it's a startup script
E: mystun no-cleaning-of-buildroot %clean
-> I was almost ready to say it's an rpmlint error, but then I noticed that rm
-rf ${buildroot} and rm -rf %{buildroot} are not really the same :)
on generated binary:
W: mystun wrong-file-end-of-line-encoding /usr/share/doc/mystun-1.0/README
W: mystun wrong-file-end-of-line-encoding /usr/share/doc/mystun-1.0/COPYING
Running dos2unix will make rpmlint happy here. Not a blocker, anyway.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL)is OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream, sha1sum is
35685456e7cbf31f831d106b19185ccea7c3952f  /tmp/mystun-1.0-source.zip
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- no static files, no libtool, no pkconfig
- scriptlets are sane, correctly Requires chkconfig and service

SHOULD
- compiles and builds happily in mock/devel/x86_64, but ignores the fedora
specific compilation flags


MUSTFIX:
- fixing the typo in %clean ($-->%) 
- the Makefile overrides CFLAGS, therefore $rpm_opt_flags is not used. Please
patch it; I did not test but I think that a simple sed similar to
"s/-DOPENSSL_NO_KRBS/-DOPENSSL_NO_KRBS (CFLAGS)/" should be enough


Andreas, please address the above. After that I'll do a test run (I am not going
to test the version which does not take the compiler flags into account since it
might be way different to the final one) and assuming no issues appear, we are
good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.