[Bug 225791] Merge Review: gettext

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gettext


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225791





------- Additional Comments From petersen at redhat.com  2007-03-13 03:37 EST -------
(In reply to comment #3)
> > * gettext mo files
> >   Cannot this be treated by %find_lang macro?
> 
> Will look into this.

Adding find_lang macros.

> >    - Would you explain the status of /usr/lib/preloadable_libintl.so?
> >      * Currently this has 0644 permission
> 
> Let me look into it.

I sent a mail upstream to ask about it.  Currently I set it 755 in the spec file.
I note however that LD_PRELOAD=/usr/lib/preloadable_libintl.so seems
to work also when the file is 644.

(In reply to comment #4)
> Well, it seems that to fix this you have to once remove
> this script from cvs and readd??
> If so, leave this as it is for now.

Ok, thanks.

> Well, on my system 'devel(libintl)' is not required by
> any package.

Ok, I removed it.

> > >    - There are many 'spurious-executable-perm' complaint.
> > >    - And somes are 'wrong-script-interpreter'
> > >    - Check if some zero-length files are needed.
> > 
> > To be honest I am tempted just to remove all the examples completely from
> > gettext-devel or at least move them to another subpackage.
> Well, these files doesn't seem to be needed...

I'm removing examples.

> Other points:
> * It may be better that "./ChangeLog" is added to %doc.
> Now I am checking all sources...

I added it to the -devel package for now, not sure how useful it is though.

(In reply to comment #5)
> * There are some test files under
:
>   Can any tests be done using the files under the directories
>   above at %check stage?

I am going to add "make check" for now, and a patch for one test that currently
fails (reported upstream). :-/
I am not sure it can always be turned on, but it is good to have it documented
in the spec file anyway.  Also the checks take quite a time to run.
I haven't used %check before but it does seem a little intrusive,
for example "make install-short" also runs it for me.


I committed the changes to cvs: they should be in gettext-0.16.1-6.fc7.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.