[Bug 227082] Review Request: maven-scm-1.0-0.b3.2jpp - Basic API for lightweight logging

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maven-scm-1.0-0.b3.2jpp - Basic API for lightweight logging


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227082


tbento at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tbento at redhat.com           |dbhole at redhat.com




------- Additional Comments From tbento at redhat.com  2007-03-13 15:22 EST -------
> X * verify source and patches (md5sum matches upstream, know what the patches do)
>   - if upstream doesn't release source drops, put *clear* instructions on
>     how to generate the the source drop; ie. 
>    # svn export blah/tag blah
>    # tar cjf blah-version-src.tar.bz2 blah
> 
>    Change 'tar czf maven-scm.tar.gz maven-scm/' to:
>    'tar czf maven-scm-1.0-beta-3.tar.gz maven-scm/'

Fixed.
 
> X * rpmlint on <this package>.srpm gives no output
>   - justify warnings if you think they shouldn't be there
>   W: maven-jxr non-standard-group Development/Java
>   W: maven-jxr no-documentation
>   W: maven-jxr non-standard-group Development/Java
>   W: maven-jxr mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 47)
>
>   First 3 are OK. Last one should be fixed.

Fixed.

> X * summary should be a short and concise description of the package
>   Summary is incorrect. Should be:
>   'Common API for doing SCM operations'

Fixed.

> X * description expands upon summary (don't include installation
>     instructions)
>   Description should change to (with 80 char limit / line):
> 
>   Maven SCM supports Maven 2.x plugins (e.g. maven-release-plugin) and other
>   tools (e.g. Continuum) in providing them a common API for doing SCM
>   operations. 

Fixed.

> X * make sure lines are <= 80 characters
>     Comment on line 117 needs to be broken up. See above.

Fixed.

When you run rpmlint on the binary RPMS, you get the following output:
W: maven-scm non-standard-group Development/Java
W: maven-scm non-conffile-in-etc /etc/maven/fragments/maven-scm
W: maven-scm-javadoc non-standard-group Development/Documentation
--> These are okay.
E: maven-scm-javadoc zero-length 
/usr/share/javadoc/maven-scm-1.0/provider-clearcase/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-starteam/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-cvs-commons/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-bazaar/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/manager-plexus/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-cvsexe/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-svn-commons/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/client/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-perforce/package-list
E: maven-scm-javadoc zero-length /usr/share/javadoc/maven-scm-1.0/api/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-cvstest/package-list
E: maven-scm-javadoc zero-length /usr/share/javadoc/maven-scm-1.0/test/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-local/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-vss/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-svnexe/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/provider-svntest/package-list
E: maven-scm-javadoc zero-length
/usr/share/javadoc/maven-scm-1.0/plugin/package-list
--> These are okay because this is an autogenerated file and beyong packager
control.
W: maven-scm-test non-standard-group Development/Java
W: maven-scm-test no-documentation
--> These can be ignored.

 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.