[Bug 227646] Review Request: grass - GRASS (Geographic Resources Analysis Support System)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grass -  GRASS (Geographic Resources Analysis Support System)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227646





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-14 15:19 EST -------
Created an attachment (id=150081)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=150081&action=view)
rpmlint log for grass-6.2.1-10

Well, for 6.2.1-10:

* Requies:
  A. for -devel:
     * lesstiff-devel - perhaps typo..

* rpmlint (attached)
  - Still complains about "undefined-non-weak-symbol", perhaps
    due to lack of the linkage against libm.so
    NOTE: This rpmlint (i.e. I wrote as "For installed rpms") can
	  be gained by:
-------------------------------------------------------
# rpmlint grass grass-devel grass-libs
-------------------------------------------------------
	  after you install grass, grass-devel, grass-libs.
	  i.e. rpmlint can be used also for installed rpms, and
	       some of the rpmlint complaints can be gained
	       only by this way.

* For grass.pc file:
  - Well, the column "Requires: <foo>" means
    * pkg-config searches <foo>.pc when pkg-config tries to use
      grass.pc
    * and pkg-config addes cflags or libs in <foo>.pc automatically
      for grass.pc

      Well, so "Requires: ncurses-devel" in grass.pc means that
      grass.pc requires "ncurses-devel.pc", which is not right.
      (and ncurses-devel does not have any pkgconfig .pc file)

      IMO Requires: on grass.pc should be:
---------------------------------------------------------
Requires: xt x11 xproto glproto
---------------------------------------------------------
      , and Cflags should have:
---------------------------------------------------------
Cflags: -I${includedir} -I/usr/include/gdal
---------------------------------------------------------
      (Well, -I/usr/include/gdal has to be added because header files
       in gdal-devel is moved to /usr/include/gdal)
      Also, prefix, exec_prefix is perhaps not right.

      However, the better idea is to add gdal.pc in gdal-devel,
      which has:
---------------------------------------------------------
prefix=/usr
exec_prefix=/usr
libdir=/usr/lib
includedir=/usr/include

Name: GDAL
Description: GIS file format library
Version: 1.4.0
Libs: -L${libdir}
Cflags: -I%{includedir}/gdal
---------------------------------------------------------
    , which is installed under %{_libdir}/pkgconfig, and fix
      grass.pc so that
---------------------------------------------------------
# Package Information for pkg-config
prefix=/usr
exec_prefix=/usr
libdir=/usr/lib
includedir=/usr/include

Name: GRASS
Description: GRASS GIS
Version: 6.2.1
Libs: -L%{libdir} -lgrass_I -lgrass_vask -lgrass_gmath -lgrass_gis
-lgrass_datetime -lgrass_gproj -lgrass_vect -lgrass_dbmibase -lgrass
_dbmiclient
Cflags: -I${includedir}/grass
Requires: xt x11 xproto glproto gdal
---------------------------------------------------------
    (on i386, ppc!! on x86_64, $libdir differ)

* For keeping timestamps:
  - For this the following seems to work (check how the timestamp
    change by adding following).
---------------------------------------------------------
# readline requires ncurses, so workaround.
# correct mysql_config query
sed -i 's|-lreadline|-lreadline -lcurses|g' configure
sed -i 's|--libmysqld-libs|--libs|g' configure

sed -i 's|^cp |cp -p |' tools/build_html_index.sh <- ADD
sed -i 's|-cp |-cp -p |' Makefile <- ADD

%build

# configure without optimizations.
# code may contain sensible buffer overflows triggered by gcc ssp flag
(mustfixupstream).
OPT_FLAGS=`echo $RPM_OPT_FLAGS|sed -e 's/-Wp,-D_FORTIFY_SOURCE=2//g'`
export CFLAGS="$OPT_FLAGS" 
export CXXFLAGS="$OPT_FLAGS" 
export CPPFLAGS="$OPT_FLAGS"
export INSTALL="%{__install} -c -p" <- ADD

---------------------------------------------------------

* For license:
  - Well, I just asked you and from your comment it seems no problem

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.