[Bug 225807] Merge Review: glib-java

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 14 22:30:41 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: glib-java


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225807





------- Additional Comments From mcepl at redhat.com  2007-03-14 18:30 EST -------
1) rpmlint is not silent on source package:
W: glib-java rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

W: glib-java mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 26)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

2) rpmlint is not silent on binary package as well:
[matej at chelcicky redhat]$ rpmlint -i RPMS/i386/glib-java-*
W: glib-java-devel summary-ended-with-dot Compressed Java source files for
glib-java.
Summary ends with a dot.

E: glib-java zero-length /usr/share/doc/glib-java-0.2.6/NEWS
W: glib-java devel-file-in-non-devel-package /usr/include/glib-java/jg_jnu.h
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

3) incorrect BuildRoot tag.
It should be (in decreasing order of preference) one of these:
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
%{_tmppath}/%{name}-%{version}-%{release}-root

4) INSTALL should not be installed

5) Check Requires and BuildRequires whether all versions are necessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list