[Bug 227646] Review Request: grass - GRASS (Geographic Resources Analysis Support System)

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 15 18:00:04 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grass -  GRASS (Geographic Resources Analysis Support System)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227646





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-15 13:59 EST -------
Created an attachment (id=150146)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=150146&action=view)
grass.pc.in (with some fix)

For -11:

* pkgconfig file:
  - Well,
------------------------------------------------
Libs: -L%{libdir} -lgrass_I -lgrass_vask -lgrass_gmath -lgrass_gis
-lgrass_datetime -lgrass_gproj -lgrass_vect -lgrass_dbmibase -lgrass_dbmiclient

------------------------------------------------
    Actually this should be "-L${libdir}", not percent. This was my
    typo, sorry...
  - Other issues are: prefix, exec_prefix, libdir, includedir for grass.pc is
not correct.

    The attached grass.pc.in should work.

  ? By the way, there are some other /usr/lib/libgrass_??.so which don't appear

    in grass.pc file. Would you know why? (perhaps because of some intention
    of upstream).

  - And for gdal.pc, the correct one is
------------------------------------------------
Libs: -L${libdir} -lgdal
------------------------------------------------
    ... my bad ...

* Optflags
  ? Not bad, and I didn't notice this, however, fedora optflags seems to be
passed twice.
------------------------------------------------
make[2]: Entering directory `/builddir/build/BUILD/grass-6.2.1/lib/datetime'
gcc -I/builddir/build/BUILD/grass-6.2.1/dist.i686-redhat-linux-gnu/include -O2
-g -pipe -Wall	-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32
-march=i386 -mtune=generic -fasynchronous-unwind-tables -O2 -g -pipe -Wall 
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
-mtune=generic -fasynchronous-unwind-tables    -fPIC   
-DPACKAGE=\""grasslibs"\"     -DPACKAGE=\""grasslibs"\" 
-I/builddir/build/BUILD/grass-6.2.1/dist.i686-redhat-linux-gnu/include \
		-o OBJ.i686-redhat-linux-gnu/between.o -c between.c
------------------------------------------------

+ Timestamps are actually fixed correctly.
+ rpmlint warnings can now all be ignored.

Well, again I will try to check all source files 
(although there are 5000+ files...) I hope that this review
is now approaching to the goal.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list