[Bug 232417] Review Request: firmware-addon-dell - A firmware-tools plugin to handle BIOS/Firmware for Dell systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firmware-addon-dell - A firmware-tools plugin to handle BIOS/Firmware for Dell systems


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232417


Matt_Domsch at dell.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From Matt_Domsch at dell.com  2007-03-15 18:04 EST -------
rpmlint results
E: firmware-addon-dell explicit-lib-dependency libsmbios-bin
 - false positive commented in spec file

W: firmware-addon-dell strange-permission firmware-addon-dell.spec 0600
 - another false positive - CVS won't have this problem of course


MUSTs:
* passes naming guidelines
* spec file name correct
* packaging guidelines:
  * name ok
  * license OK
  * nothing prebuilt
  * files FHS
  * passes rpmlint
  * has changelog
  * no packager tag
  * no vendor tag
  * has license tag
  * summary doesn't end in .
  * no PreReq
  * Source0 needs fixing!!!
  * buildroot OK
  * requires ok
  * summary and description ok
  * encoding UTF8
  * documentation ok
  * optflags unneeded
  * debuginfo not disabled
  * no static libs
  * no system library dupes
  * no rpath
  * config is noreplace, not in /usr
  * no initscripts
  * no desktop file needed
  * uses macros not hard-coded dirs
  * consistent use of macros
  * no locales
  * no copying of files in setup
  * no parallel make as no make
  * no scriptlets
  * no conditional deps
  * builds in mock with separate user
  * not relocatable
  * is code, not content
  * files and dirs owned properly
  * not a web app

* License is GPL/OSL dual, ok
* License tag OK
* licenses in %doc
* spec in english
* spec legible
* sources match upstream
* compiles and builds on all arches (it's noarch)
* BuildRequires correct
* No locales to care about
* no shared libs
* not relocatable
* owns the dirs it creates
* no dup files
* defattr present
* file permissions ok
* consistent use of macros
* contains code
* no need for separate -doc
* %doc files present but not critical for runtime
* no headers
* no static libs
* no .pc files
* no shared libs
* no -devel
* no libtool archives
* no desktop file needed
* directory ownership ok

SHOULDs:
* licenses present upstream
* no translations - ok
* builds in mock
* builds into noarch
* runs fine
* no scriptlets
* no subpackages
* no .pc files
* no file deps


APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.