[Bug 231984] Review Request: Vym - View Your Mind

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Vym - View Your Mind


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231984





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-16 13:38 EST -------
For 1.8.1-3:

* Desktop file
-------------------------------------------------
Icon=%{_datadir}/icons/hicolor/16x16/vym.png
-------------------------------------------------
  - This is incorrect. This must be:
-------------------------------------------------
Icon=vym.png
-------------------------------------------------
    or
-------------------------------------------------
Icon=vym
-------------------------------------------------

* BuildRequires:
  - Would you explain why "kdelibs" is needed for BuildRequires?

* Timestamps
  - The following is okay for this package.
-------------------------------------------------
%{__make} install DESTDIR=%{buildroot} COPY="%{__cp} -p -f"
-------------------------------------------------

??
  - Why do you write the following?
-------------------------------------------------
## File lists
# locale's
%find_lang %{name} || touch %{name}.lang
# HTML (1.0)
HTML_DIR=$(kde-config --expandvars --install html)
if [ -d %{buildroot}$HTML_DIR ]; then
......
fi
-------------------------------------------------
    I don't see the necessity of these scripts.

* Documentation location
-------------------------------------------------
%{__rm} -rf %{buildroot}%{_docdir}/packages/%{name}
-------------------------------------------------
  - Now, when I try to
    -- launch yum
    -- "Help" -> "Open VYM Documentation (pdf)"
    Then:
-------------------------------------------------
Couldn't find the documentation
vym.pdf in various places.
-------------------------------------------------
    - Fix mainwindow.cpp around the line 2780.

* Directory ownership
  - Why is the following empty directory needed?
-------------------------------------------------
/usr/share/vym/styles/wiki
-------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.