[Bug 232618] Review Request: perl-XML-Filter-BufferText - Filter to put all characters() in one event

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-Filter-BufferText - Filter to put all characters() in one event


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232618


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |ville.skytta at iki.fi
               Flag|                            |fedora-review?




------- Additional Comments From ville.skytta at iki.fi  2007-03-16 17:39 EST -------
* Wrong permissions on installed files, there's no need for these to be
executable (please use rpmlint before submitting to save reviewer time):

E: perl-XML-Filter-BufferText script-without-shebang
/usr/lib/perl5/vendor_perl/5.8.8/XML/Filter/BufferText.pm
W: perl-XML-Filter-BufferText spurious-executable-perm
/usr/share/doc/perl-XML-Filter-BufferText-1.01/README
W: perl-XML-Filter-BufferText spurious-executable-perm
/usr/share/doc/perl-XML-Filter-BufferText-1.01/Changes

* Use "BuildRequires: perl(ExtUtils::MakeMaker)" - that'll work for all distro
versions without need to do %if %fedora conditionals.

* Dependency on perl(XML::SAX::Base) missing - the auto dep generator doesn't
know how to extract dependencies from "use base qw(...)"

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.