[Bug 232702] Review Request: perl-Compress-Raw-Bzip2 - Low-Level Interface to bzip2 compression library
bugzilla at redhat.com
bugzilla at redhat.com
Sat Mar 17 19:14:52 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Compress-Raw-Bzip2 - Low-Level Interface to bzip2 compression library
------- Additional Comments From andreas at bawue.net 2007-03-17 15:14 EST -------
+ source files match upstream: ebe26a1ca9aae874eada7636cf779d33
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ license is "GPL or Artistic".
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ $RPM_OPT_FLAGS are being used.
+ %clean is present.
+ package installs properly
+ debuginfo package contains data.
+ rpmlint is silent.
+ final provides and requires are sane:
perl-Compress-Raw-Bzip2 = 2.004-1.fc7
perl >= 0:5.004
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
- %check is present and all supported tests pass. However, Test::POD would be
useful as a BR
all skipped: Test::Pod 1.00 required for testing POD
All tests successful, 1 test skipped.
Files=3, Tests=158, 1 wallclock secs ( 0.27 cusr + 0.05 csys = 0.32 CPU)
+ no shared libraries are added to the regular linker search paths.
+ no duplication of system libraries.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
MUST and SHOULD parts do look okay. I would suggest however adding a
BuildRequire for perl(Test::POD). That way you can prevent the skipping of the
Otherwise you can consider that package approved.
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review