[Bug 226526] Merge Review: vim

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: vim


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226526


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |ruben at rubenkerkhof.com
               Flag|                            |fedora-review?




------- Additional Comments From ruben at rubenkerkhof.com  2007-03-18 08:11 EST -------
Hi Karsten,

Needs work:
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* rpmlint of vim-common: 
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Each %files section should have a %defattr line
  (wiki: Packaging/ReviewGuidelines)
* Desktop file: vendor should be fedora
  (wiki: PackagingGuidelines#desktop)
* Scriptlets: missing update-desktop-database
  (wiki: ScriptletSnippets)
* The package owns /usr/share/man/fr, which is a standard directory
  (wiki: Packaging/ReviewGuidelines)
* The package owns /usr/share/man/fr/man1, which is a standard directory
  (wiki: Packaging/ReviewGuidelines)
* The package owns /usr/share/man/it, which is a standard directory
  (wiki: Packaging/ReviewGuidelines)
* The package owns /usr/share/man/it/man1, which is a standard directory
  (wiki: Packaging/ReviewGuidelines)
* The package owns /usr/share/man/pl, which is a standard directory
  (wiki: Packaging/ReviewGuidelines)
* The package owns /usr/share/man/pl/man1, which is a standard directory
  (wiki: Packaging/ReviewGuidelines)

Some minor things:
* Please use BuildRequires instead of Buildrequires everywhere
* Preserve timestamps when installing non-generated files
* Please run rpmlint on all rpms and fix the warnings and errors. The list is a bit long to include here.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.