[Bug 232873] Review Request: compat-guichan05 - compatibility libraries for guichan

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-guichan05 - compatibility libraries for guichan


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232873


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
               Flag|                            |fedora-review?




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-03-19 07:16 EST -------
Hi,

1 problem and one question:

Problem: it doesn't build on rawhide i386, and I cannot see the errors as it
adds: "> /dev/null 2>&1" to all compile commands, please remove this so that I
can see the error (and warnings).

Question / remark:
I notice that you've added -release %{version} to the LDFLAGS for this. This
hads pros and cons:
-pro, this way non Fedora packages / binaries (which may expect libguichan.so.0)
 will not find this, which is good as there is on way to know which version of'
 guichan they are actually looking for
-con, this way it will not be ABI compatible (because of the different soname)
 with the current guichan package, and thus guichan may only be updated in 
 devel.

What I actually had in mind was adding -release %{version} to the new
guichan-0.6.1 . Notice that we must do this independend of what we do with
compat-guichan, to avoid having the same problem in the future.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.