[Bug 212003] Review Request: mugshot - Companion software for mugshot.org

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mugshot - Companion software for mugshot.org


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212003





------- Additional Comments From otaylor at redhat.com  2007-03-19 15:06 EST -------
- I've added AM_DISABLE_STATIC svn mugshot and an rm for the .la file to my
  local copy of the spec file.

- I agree with Peter that the complaint about the schema files missing
  %config is a false positive; despite being in /etc, gconf schema 
  files are not configuration.

- desktop-file-install. Hmm. I disagree with the packaging guidelines:
 
   - The fedora- prefix is pointless and a misundestanding of the
     text about vendor prefixes in the menu specification (it would
     be the same thing as having all the binaries in /usr/bin start
     with fedora- ... the point of vendor prefixes is collision
     prevention.)

   - The only thing that desktop-file-install here will do is validate
     the desktop file and force a prefix to be added.

   - The desktop file being installed is actually for autostart and
     not a menu desktop file under /usr/share/applications (adding it
     to the menu is intentionally not been done.)

  But that's really off-topic here... Luckily --vendor=mugshot does the
  right thing, so I'll just add to the spec file:

   desktop-file-install                                \
     --dir=$RPM_BUILD_ROOT%{_datadir}/gnome/autostart  \ 
     --vendor=mugshot                                  \
     mugshot.desktop

  so that we get the validation without mucking up the name. I don't
  want to use desktop-file-install in the Makefile since I don't see
  a point in putting a d-f-u dependency on the tarball build. 
  (As you say, desktop-file-validate would be a different option;
  Leaving it as desktop-file-install, maybe it will do something
  genuinely useful some day)

I'll attach a new version of the spec file, but all changes are described
above (with the spec file and 1.1.38, it will still package a .a file 
for the Firefox extension; there will be a 1.1.39 sometime in the next
few days with the AM_DISABLE_STATIC)

Thanks a lot for the careful review!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.