[Bug 233070] gnome-web-photo: HTML pages thumbnailer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: gnome-web-photo: HTML pages thumbnailer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233070


peter at thecodergeek.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |peter at thecodergeek.com




------- Additional Comments From peter at thecodergeek.com  2007-03-21 01:43 EST -------
Not a full review, but some comments from looking over the spec file:

* For your URL tag, Is there a specific reason for choosing the ftp.acc.umu.se
mirror rather than the round-robin ftp.gnome.org hostname?

* Your Source0 tag should be a fully-qualified URL to the tarball; or if it's a
Fedora-hosted project (wherein this packaging *is* the upstream source), you
should add a comment to note it as such.

* Does it really need the gettext development environment, or does it just use
the gettext utilities for its translation merging while building? If it just
uses the utilities, then please change the "BuildRequires: gettext-devel" to
simply "BuildRequires: gettext"

* You don't need a build-time dependency on libpng-devel, since it's a
dependency of gtk2-devel. Similarly, gnome-vfs2-devel has a depenency on
GConf2-devel, so you should remove libpng-devel and GConf2-devel from your
BuildRequires since they are duplicated entries.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.