[Bug 233139] Review Request: SDLmm - C++ interface for the popular SDL library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SDLmm - C++ interface for the popular SDL library
Alias: SDLmm

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233139


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From chris.stone at gmail.com  2007-03-21 12:35 EST -------
I believe the new patch adds these warnings:
sdlmm_audio.cpp
sdlmm_srect.cpp: In function 'SDLmm::SRect SDLmm::Intersect(const SDLmm::SRect&,
const SDLmm::SRect&)':
sdlmm_srect.cpp:77: warning: comparison is always false due to limited range of
data type
sdlmm_srect.cpp:78: warning: comparison is always false due to limited range of
data type
sdlmm_srect.cpp: In function 'SDLmm::SRect SDLmm::Union(const SDLmm::SRect&,
const SDLmm::SRect&)':
sdlmm_srect.cpp:88: warning: comparison is always true due to limited range of
data type
sdlmm_srect.cpp:89: warning: comparison is always true due to limited range of
data type

Should investigate, but not a blocker.

All other must fix items have been fixed.

*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.